Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve completer #3189

Merged
merged 4 commits into from Apr 17, 2013
Merged

Improve completer #3189

merged 4 commits into from Apr 17, 2013

Conversation

juhasch
Copy link
Contributor

@juhasch juhasch commented Apr 16, 2013

  • set tag to style="width: auto" to fit complete autocomplete string in drop down menu handle special keys better, so shift, ctrl, pgup, pgdown et al work as expected in the drop down list (i.e. pgup/pgdown/home/end move selection, shift, ctrl, caps lock do not restart the drop down menu)

@minrk
Copy link
Member

minrk commented Apr 17, 2013

Add COMMAND : 91 to the keycodes, then I think this should be set.

@minrk
Copy link
Member

minrk commented Apr 17, 2013

great, thanks!

minrk added a commit that referenced this pull request Apr 17, 2013
@minrk
Merge pull request #3189 from juhasch/improve-completer
5e33c14 
fix notebook completer redraw on metakey press

- set <select> tag to style="width: auto" to fit complete autocomplete string in drop down menu
- handle special keys better, so shift, ctrl, pgup, pgdown et al work as expected in the drop down list (i.e. pgup/pgdown/home/end move selection, shift, ctrl, caps lock do not restart the drop down menu)
@minrk minrk merged commit 5e33c14 into ipython:master Apr 17, 2013
@Carreau Carreau mentioned this pull request Jul 10, 2013
Closed
@juhasch juhasch deleted the improve-completer branch August 4, 2014 18:55
mattvonrocketstein pushed a commit to mattvonrocketstein/ipython that referenced this pull request Nov 3, 2014
@minrk
Merge pull request ipython#3189 from juhasch/improve-completer
7b81790 
fix notebook completer redraw on metakey press

- set <select> tag to style="width: auto" to fit complete autocomplete string in drop down menu
- handle special keys better, so shift, ctrl, pgup, pgdown et al work as expected in the drop down list (i.e. pgup/pgdown/home/end move selection, shift, ctrl, caps lock do not restart the drop down menu)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@juhasch @minrk