Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix callbacks as optional in js kernel.execute #3294

Merged
merged 2 commits into from May 11, 2013
Merged

Conversation

Carreau
Copy link
Member

@Carreau Carreau commented May 9, 2013

plus some doc fixes.
Mainly to fix some backward compatibility with examples here and there.

plus some doc fixes.
Mainly to fix some backward compatibility with examples here and there.
* @param callback.'output' {function}
* @param callback.'clear_output' {function}
* @param callback.'set_next_input' {function}
* @param [callbacks] {Object} With the optionnal following keys
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

optional

@ellisonbg
Copy link
Member

Once the typo Min found is fixed, this can be merged.

@Carreau
Copy link
Member Author

Carreau commented May 11, 2013

Typo fixed. Merging.

Carreau added a commit that referenced this pull request May 11, 2013
fix callbacks as optional in js kernel.execute
@Carreau Carreau merged commit 9876542 into ipython:master May 11, 2013
@Carreau Carreau deleted the jsfix branch May 11, 2013 12:52
mattvonrocketstein pushed a commit to mattvonrocketstein/ipython that referenced this pull request Nov 3, 2014
fix callbacks as optional in js kernel.execute
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants