fix test_find_cmd_python #3342
fix test_find_cmd_python #3342
Conversation
It's a bit unclear what should be done here. 'python' is short-circuited in find_cmd to sys.executable. This commit does the same short-circuit with basename(sys.executable), which can be any of Python, python, python3, python3.exe, etc. An alternate fix would be to change the test back to testing what the code actually did.
|
I don't think there's anywhere in the codebase that actually calls find_cmd on Python (by any name), other than the tests for it. I wonder if we should just drop the special case and the test for it, and let Returning |
|
I think that makes sense - I've removed the special case and the test. |
|
Do we want to also update the Windows-only test for finding pythonw? Is there some binary that should always be on the path in Windows? I don't think it's causing any problems, though, so I'm happy to leave it as is. |
|
Merging this so we can get the Windows tests passing again. |
fix test_find_cmd_python
It's a bit unclear what should be done here. 'python' is short-circuited in find_cmd to sys.executable. This commit does the same short-circuit with basename(sys.executable), which can be any of Python, python, python3, python3.exe, etc.
An alternate fix would be to change the test back to testing what the code
actually did.