start basic tests of ipcluster Launchers #3351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes AttributeError on profile_dir in SSHProxyEngineSetLauncher also adds SSHProxyEngineSetLauncher to ssh launcher collection, which adds it to the generated config files, help output, etc.
doesn't do much at the moment, but at least makes basic exercise of constructing objects
|
merging soon if no objection |
Carreau
added a commit
that referenced
this pull request
May 30, 2013
start basic tests of ipcluster Launchers
mattvonrocketstein
pushed a commit
to mattvonrocketstein/ipython
that referenced
this pull request
Nov 3, 2014
start basic tests of ipcluster Launchers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They don't do much right now, other than constructing objects and ensuring a few basic things work.
We can't feasibly exercise the full functionality of each launcher given the environment requirements, but this tests a few known errors and fixes one bug.
It should at least give a place to add future regression tests.