catch socket.error in utils.localinterfaces #3354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
instead of socket.gaierror, which is a more specific subclass. Some failures (e.g. connection timeouts) are not gaierrors. Alternately, we might want to just catch any Exception.
|
Great, fixes the problem. Thanks! Merging now. |
fperez
added a commit
that referenced
this pull request
May 23, 2013
catch socket.error in utils.localinterfaces, instead of socket.gaierror, which is a more specific subclass. This protects against certain failures seen on Ubuntu 13.04 but which could conceivably happen elsewhere.
|
mro shows that our choices, in descending specificity are: socket.error Depending on how certain we want to be that the import never fails. Exception would be safest, but might be annoying because it would hide things like NameErrors on typos. |
|
I think this is fine, we should only broaden this based on evidence that it's too narrow. I found evidence that gaierror was too specific, let's stick with |
mattvonrocketstein
pushed a commit
to mattvonrocketstein/ipython
that referenced
this pull request
Nov 3, 2014
catch socket.error in utils.localinterfaces, instead of socket.gaierror, which is a more specific subclass. This protects against certain failures seen on Ubuntu 13.04 but which could conceivably happen elsewhere.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
instead of socket.gaierror, which is a more specific subclass. Some failures
(e.g. connection timeouts) are not gaierrors.
Alternately, we might want to just catch any Exception.