New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
move anchor-link off of heading text #3357
Conversation
avoids confusion about where to click, matching Sphinx-style output. Moves the relevant style to textcell.less
merging soon if no objection |
No objection. Could the same thing be done purely with css ?
instead of binding one more js event? |
might be, I will give it a try. |
yup, much better. Had to use |
$('<a/>') | ||
.addClass('anchor-link') | ||
.attr('href', '#' + link) | ||
.html('¶') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
which is faster .text(...)
or .html(...)
I guess here you use html() to escape to the html sequence ...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
might as well use text, I guess
Ah, because display can be block or inline... maybe. Good to merge for me. |
Ok, merging. |
move anchor-link off of heading text
move anchor-link off of heading text
avoids confusion about where to click, matching Sphinx-style output with a clickable
¶
, only drawn on hover.Also moves the relevant style to textcell.less, since it only affects heading cells.