make cookie_secret configurable #3373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
instead of random. The random cookie name meant that every time you restarted the notebook it would get a new key in the cookie for the same host, resulting in an ever-growing cookie full of obsolete data.
allows config to specify logins that survive across server instances (default behavior unchanged). Depends on PR ipython#3372
|
I suppose this replace #3372 ? |
No, it's separate, but it depends on it. |
|
I just re-read the title/description and now I know why you asked - I took them from the wrong commit. This should actually describe the PR now. |
| cookie_secret = Bytes(b'', config=True, | ||
| help="""The random bytes used to secure cookies. | ||
| By default this is a new random number every time you start the Notebook. | ||
| Set it to a value in a config file to enable logins to persist across server sessions. |
There was a problem hiding this comment.
Do you want to add a warning "do not shared config files with cookies secret in it" ?
Also we could make the cookie secret maybe in another file in the security folder, or elsewhere.
you configure a path, and if this path is set then server write a random key on it and is able to find it next time.
There was a problem hiding this comment.
Ah, yes, config files are python file, you can read it from here... so merging away.
Carreau
added a commit
that referenced
this pull request
Jun 4, 2013
make cookie_secret configurable Allows config to specify logins that survive across server instances (default behavior unchanged). Add warning about not sharing config files with cookie secret.
mattvonrocketstein
pushed a commit
to mattvonrocketstein/ipython
that referenced
this pull request
Nov 3, 2014
make cookie_secret configurable Allows config to specify logins that survive across server instances (default behavior unchanged). Add warning about not sharing config files with cookie secret.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
allows config to specify logins that survive across server instances (default behavior unchanged).
Depends on PR #3372