Provide means for starting the Qt console maximized and with the menu bar hidden

[dankilman]

Not sure if this is exactly the correct approach to using the config, but what I wanted was the option to start the Qt console as mentioned above.
to use:
IPythonQtConsoleApp.hide_menubar = True
IPythonQtConsoleApp.start_maximized = True

I'm also not sure where should the documentation for these be put.

[ivanov]

Hi @dankilman - thanks for your contribution. I haven't checked if the implementation you provide works, but here's a simple patch that demonstrates how you can integrate with the config system, and get the documentation / help string to show up when a user would do ipython qtconsole --help-all:

diff --git a/IPython/frontend/qt/console/qtconsoleapp.py b/IPython/frontend/qt/console/qtconsoleapp.py
index 3aba384..cfe140e 100644
--- a/IPython/frontend/qt/console/qtconsoleapp.py
+++ b/IPython/frontend/qt/console/qtconsoleapp.py
@@ -166,6 +166,8 @@ class IPythonQtConsoleApp(BaseIPythonApplication, IPythonConsoleApp):
     stylesheet = Unicode('', config=True,
         help="path to a custom CSS stylesheet")

+    weirdo_option = CBool(False, config=True, help="this is a weirdo option")
+
     plain = CBool(False, config=True,
         help="Use a plaintext widget instead of rich text (plain can't print/save).")

and with a change like that, the docs show up when you run:

$ ipython qtconsole --help-all | grep -A1 weirdo
--IPythonQtConsoleApp.weirdo_option=<CBool>
    Default: False
    this is a weirdo option

So go ahead and add another commit (or better yet, if you're feeling adventures, make the changes and then --amend this commit and make the first line say something in just 50 character. You'll have to force when you git push this branch, afterward, but that's ok, since it's just your working copy)

[dankilman]

Thanks. Looks better now.

[minrk]

I don't think these need aliases. Everything is still configurable, even without aliases.

[ellisonbg]

What exactly does hide_menubar hide? On OS X, I don't see a difference?

Also, maybe the simpler name maximize?

[dankilman]

@ellisonbg It silently ignores hide_menubar configuration on OSX. I tested this on linux.
I simply repeated the logic I saw MainWindow.init_menu_bar() which doesn't provide an option to toggle the menu bar as its always displayed.
As to the name maximize - Agreed.

[ellisonbg]

Ahh, great I missed the skip logic on OS X. Once you change the name I will give it another review and merge. Thanks!

[dankilman]

@ellisonbg Done.

[minrk]

I don't think we need these aliases, every configurable is always available, even if they aren't added to the shortlist.

[dankilman]

Is this a duplicate of your previous comment?
I removed the aliases.

[minrk]

Sorry, yes. I thought I forgot to make that comment. Please ignore me :)

[ellisonbg]

Looks great, merging.