fix cell execution in firefox, closes #3447 #3453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
location.origin is specific to WebKit only. The fix is to use a combination of location.protocol and location.host
Closed
|
Not quite true, as FF >= 21.0 supports location.origin, but this seems like an important fix. Merging. Thanks! |
minrk
added a commit
that referenced
this pull request
Jun 21, 2013
fix websocket connection in old Firefox location.origin is a too recent addition. closes #3447
mattvonrocketstein
pushed a commit
to mattvonrocketstein/ipython
that referenced
this pull request
Nov 3, 2014
fix websocket connection in old Firefox location.origin is a too recent addition. closes ipython#3447
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
location.origin is specific to WebKit only. The fix is to use a
combination of location.protocol and location.host