Get Tracer working after ipapi.get replaced with get_ipython #3511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -206,6 +206,10 @@ def __init__(self,color_scheme='NoColor',completekey=None, | |||
|
|
|||
| self.shell = get_ipython() | |||
|
|
|||
| if self.shell is None: | |||
| from IPython.core.interactiveshell import InteractiveShell | |||
There was a problem hiding this comment.
This should probably be IPython.terminal.interactiveshell.TerminalInteractiveShell
There was a problem hiding this comment.
Also add a comment to the effect of:
# no IPython instance running, we must create one
Commit 790f731 replaced `ipapi.get` with a `get_ipython` function, that changed the API slightly, returning None when no InteractiveShell instance has been registered.
minrk
added a commit
that referenced
this pull request
Jul 2, 2013
Get Tracer working when no IPython instance is running
mattvonrocketstein
pushed a commit
to mattvonrocketstein/ipython
that referenced
this pull request
Nov 3, 2014
Get Tracer working when no IPython instance is running
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit 790f731 replaced
ipapi.getwith aget_ipythonfunction,that changed the API slightly, returning None when no InteractiveShell
instance has been registered.