Fixing issue preventing the correct read of images by full_html and reveal exporters.

[damianavila]

Currently to see and images in the notebook inside a md cell you can use the prefix files/ to read the content of the directory where the ipynb lives. But, if you do a conversion using full_html or reveal exporters, the are not rendered ok because the previous version of this function erased /files/ instead of files/. With this fix, the html files produced by full_html and reveal exporters can read the images in a correct way.

[Carreau]

actually, it would even be better if it removed only the first occurences in each url... it might be a little complicated though.

[minrk]

The logical fix you have made is right, but now the filter can be much too aggressive. This replacement should only ever apply inside urls, and only if the URL starts with files/.

[minrk]

Try this replacement:

    for attr in ('src', 'href'):
        for q in ('"', "'"):
            prefix = "{attr}={q}".format(attr=attr, q=q)
            text = text.replace(prefix + "files/", prefix)
    return text

And change the description to say that it only replaces URLs that start with files/.

I'm sure this can be done with a single re.sub call, but I don't want to figure out the right expression.

[minrk]

Actually, the regular expression is easy, if you want to just cherry-pick / merge a38edc4 into this PR.

[damianavila]

I have problems cherry-picking / merging this one... maybe because I don't know enough from git...

My problem is fetching your code... I think is derived from my PR, but I could not find it any logical way to fetch it... any suggestion?

[minrk]

To add my changes to your repo:

git remote add minrk git://github.com/minrk/ipython.git
git fetch minrk

To add the changeset to your branch:

git cherry-pick a38edc4
# or
git merge minrk/pr/3550
# or, to be forceful if the others don't work for some reason:
git reset minrk/pr/3550 --hard

[damianavila]

Thanks, I tried exactly what you explained... It has to be some typo... I will do it again and let you know

[damianavila]

OK, done with the cherry-picking... cheking the history of my commands, it was a typo... grrr...

Anyways... it is working right here. I hope this could be merged soon.

[minrk]

Yup, 👍 for me, but I probably shouldn't be the last word, since I wrote the regex. @Carreau?

[Carreau]

looks ok to me.

[damianavila]

Thanks!