Remove max_msg_size

[minrk]

The max_msg_size safety limit is just removed.

to 1MB. 64k is probably too conservative (1MB may be as well, I'm not sure of the value of this configurable, really).

Also warn about the dropped messages, so that there is a hint about the cause of strange behavior.

closes #3124

[Carreau]

should we wait for @ellisonbg input to merge ?

[ellisonbg]

I think the idea was to mitigate denial of service attacks, But I honestly don't know if this configurable would even help.

Sent from my iPhone

On Jul 5, 2013, at 10:19 PM, Min RK notifications@github.com wrote:

to 1MB. 64k is probably too conservative (1MB may be as well, I'm not sure of the value of this configurable, really).

Also warn about the dropped messages, so that there is a hint about the cause of strange behavior.

You can merge this Pull Request by running

git pull https://github.com/minrk/ipython longcell
Or view, comment on, or merge it at:

#3560

Commit Summary

up default max_msg_size to 1MB
warn about messages dropped due to oversize
File Changes

M IPython/html/notebookapp.py (4)
M IPython/html/services/kernels/handlers.py (6)
Patch Links:

https://github.com/ipython/ipython/pull/3560.patch
https://github.com/ipython/ipython/pull/3560.diff

[minrk]

Should we just remove it, then? Remember, this code is only hit after the connection has been established as valid and authenticated.

[Carreau]

+1 for removing limit alltogether.

[minrk]

This PR now removes max_msg_size entirely

[ellisonbg]

I am fine with that.

On Tue, Jul 9, 2013 at 9:37 AM, Min RK notifications@github.com wrote:

This PR now removes max_msg_size entirely

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/3560#issuecomment-20687419
.

Brian E. Granger
Cal Poly State University, San Luis Obispo
bgranger@calpoly.edu and ellisonbg@gmail.com

[andycjw]

long multiline input takes forever to run and i'm using 3.1.0-cbccb68.
the string is only 100000 in char length, and it's not working for me