add extra_config_file #3592
add extra_config_file #3592
Conversation
and `--config` alias
for loading a single extra config file, e.g.
ipython notebook --config mycfg.py
which will be strictly in addition to, and at higher priority than, existing config files, profiles, etc.
Note that the loading code hasn't changed, it's just indented to put it in a for-loop.
it's a set now
| @@ -84,14 +85,14 @@ class BaseIPythonApplication(Application): | |||
|
|
|||
| # Track whether the config_file has changed, | |||
| # because some logic happens only if we aren't using the default. | |||
| config_file_specified = Bool(False) | |||
| config_file_specified = Set() | |||
There was a problem hiding this comment.
I guess I am not quite following why this should be a Set...
There was a problem hiding this comment.
It's a bit more generic now, and can track more than one value.
|
Could you explain the rationale for this a bit more? I'm a bit wary of adding more complexity to the config system, especially as, from discussions at SciPy, we might want to add another degree of complexity in some form of declarative config files. |
|
The main point is for nbconvert. @ellisonbg and @jdfreder are writting the CL tool and want to have a config file on a per folder basis to be able to do |
|
OK, that makes sense, and I don't see any simpler way to achieve it. On 10 July 2013 12:53, Matthias Bussonnier notifications@github.com wrote:
|
|
#3607 👍 |
|
👍 for me! |
add extra_config_file and --config alias for loading a single extra config file, e.g. ipython notebook --config mycfg.py which will be strictly in addition to, and at higher priority than, existing config files, profiles, etc. Note that the loading code hasn't changed, it's just indented to put it in a for-loop. This is added primarily for nbconvert, but the NbConvertApp will need to be fixed to properly inherit flags and aliases from the base application, like all other IPython apps.
fix regression in #3592 preventing default config files from loading
add extra_config_file and --config alias for loading a single extra config file, e.g. ipython notebook --config mycfg.py which will be strictly in addition to, and at higher priority than, existing config files, profiles, etc. Note that the loading code hasn't changed, it's just indented to put it in a for-loop. This is added primarily for nbconvert, but the NbConvertApp will need to be fixed to properly inherit flags and aliases from the base application, like all other IPython apps.
fix regression in ipython#3592 preventing default config files from loading
and
--configaliasfor loading a single extra config file, e.g.
which will be strictly in addition to, and at higher priority than, existing config files, profiles, etc.
Note that the loading code hasn't changed, it's just indented to put it in a for-loop.
This is added primarily for nbconvert, but the NbConvertApp will need to be fixed to properly inherit flags and aliases from the base application, like all other IPython apps.