Fix duplicate completion in notebook #3594
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ping @takluyver |
| { return true; } | ||
| } | ||
| for( var c in completion_array ) { | ||
| if(completion_array[c].replace(/^\s+|\s+$/g,'').substr(-item.length) == item) |
There was a problem hiding this comment.
A quick search suggests that we can .trim() instead of regexing it in all modern browsers.
|
Thanks - I don't have time to test at present, but I'll trust you that it does the job ;-) |
Changed to |
comparaison between kernel completion and context-completin were returning duplicate entry in some cases, due to trailing space. sripping trailing space in comparaison prevent this. fixes ipython#3563 example import bar from foo im<tab> used to propose `import` twice (actually `import` and `import[space]` as$ `import` was a token on the first line) now just complete directly to$ `import[space]`.
|
Works for me. |
minrk
added a commit
that referenced
this pull request
Jul 10, 2013
Fix duplicate completion in notebook comparaison between kernel completion and context-completin were returning duplicate entry in some cases, due to trailing space. sripping trailing space in comparaison prevent this. closes #3563
mattvonrocketstein
pushed a commit
to mattvonrocketstein/ipython
that referenced
this pull request
Nov 3, 2014
Fix duplicate completion in notebook comparaison between kernel completion and context-completin were returning duplicate entry in some cases, due to trailing space. sripping trailing space in comparaison prevent this. closes ipython#3563
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
comparaison between kernel completion and context-completin were
returning duplicate entry in some cases, due to trailing space.
sripping trailing space in comparaison prevent this.
fixes #3563
example
used to propose
importtwice (actuallyimportandimport[space]asimportwas a token on the first line) now just complete directly toimport[space].