catch any exception appending output #3621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HTML output can have javascript with errors, etc. No output should ever raise, no matter what. closes ipython#3620
|
+1 |
| .html("Javascript error adding output!<br/>" + | ||
| err.toString() + | ||
| '<br/>See your browser Javascript console for more details.') | ||
| .addClass('js-error') |
There was a problem hiding this comment.
so hey, fish out of whater in all this js, but don't you need to still append the updated toinsert after an error is caught, or does that get updated live somehow in the place where it already lives?
There was a problem hiding this comment.
In the tests I have run (html with bad javascript tag), the toinsert element is actually attached to the DOM before the error is raised (the attaching to the document is what results in the javascript actually executing, which in turn results in the exception). I suppose it is technically possible that the element appending would fail, but I haven't seen it happen, and might require a jQuery bug.
minrk
added a commit
that referenced
this pull request
Jul 16, 2013
catch any exception appending output HTML output can have javascript with errors, etc. No output should ever raise, no matter what. closes #3620
mattvonrocketstein
pushed a commit
to mattvonrocketstein/ipython
that referenced
this pull request
Nov 3, 2014
catch any exception appending output HTML output can have javascript with errors, etc. No output should ever raise, no matter what. closes ipython#3620
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HTML output can have javascript with errors, etc.
No output should ever raise, no matter what.
closes #3620