Fix test for Python 3 on Windows. #3628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IPython.core.tests.test_run.test_aggressive_namespace_cleanup
|
Note I haven't tested the fix on Windows, but it should work if I've understood the issue properly. I recommend that we merge it and see if it fixes the ShiningPanda runs. |
|
I can test it on windows later on today, if that helps, @takluyver. And actually, whenever you need windows testing now, feel free to ping me, since I'm back to being fully active, I'll actually do it |
|
If you don't get to it this weekend, I will be doing lots of Windows testing starting Monday, so @takluyver's PRs should get in promptly. |
|
tested and confirmed fix. |
minrk
added a commit
that referenced
this pull request
Jul 15, 2013
…-cleanup Fix test for Python 3 on Windows.
mattvonrocketstein
pushed a commit
to mattvonrocketstein/ipython
that referenced
this pull request
Nov 3, 2014
…mespace-cleanup Fix test for Python 3 on Windows.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IPython.core.tests.test_run.test_aggressive_namespace_cleanup was recently enabled, but the test itself had a problem under Python 3 and Windows:
https://jenkins.shiningpanda-ci.com/ipython/job/ipython-win-py33/24/console