CSS adjustments #3630
CSS adjustments #3630
Conversation
it is redundant with bootstrap reset
adds static/style/ipython.less and ipython.min.css Which should contain minimal styling that conflicts with other CSS. As we improve our CSS scoping and naming, this file should eventually be enough to play nice with embedding IPython in other HTML contexts.
allows it to be excluded from ipython.min.css, where it doesn't make much sense.
|
I'll try to take a look at this tomorrow. Are you hoping to get these changes into the 1.0 release? |
|
Yes - it doesn't actually change anything, it's just a new file without all the bootstrap CSS included. It's not used in the live notebook. It would only be for use in embedding notebooks in other environments. |
|
Tried it out -- this is fixing a lot of the problems I was having! The one thing that still will require a fair bit of tweaking is this: The section headings are rendered as, e.g. The existence of the |
|
N I don't think the p tag inside the heading are by design, I would say it is a bug. |
|
It is definitely a bug, and should also be fixed by #3601. |
Yes, that seems to have fixed it! |
|
With that issue addressed, I'm +1 for this PR to be merged. I've tried html renderings of a variety of notebooks and haven't found any other issues. In addition, using this branch I now have a nice prototype version of my Pelican plugin, and the in-blog notebook renderings look great. |
|
Great, will merge then. We can always improve things further in the future. |
CSS adjustments - remove boilerplate.css, as it is redundant with bootstrap's own reset.less - add ipython.less / ipython.min.css for IPython-only CSS - move font-awesome to outermost style.less, so it is not included in ipython.min.css, where it is not desirable. This doesn't do any of the naming / scoping cleanup that we should ultimately do, but it does create the file where that will have its desired effect.
CSS adjustments - remove boilerplate.css, as it is redundant with bootstrap's own reset.less - add ipython.less / ipython.min.css for IPython-only CSS - move font-awesome to outermost style.less, so it is not included in ipython.min.css, where it is not desirable. This doesn't do any of the naming / scoping cleanup that we should ultimately do, but it does create the file where that will have its desired effect.
where it is not desirable.
This doesn't do any of the naming / scoping cleanup that we should ultimately do, but it does create the file where that will have its desired effect.
Ping @jakevdp for comments on how well ipython.min.css actually plays with embedding in other environments.