Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove notebook read-only view #3743

Merged
merged 1 commit into from Jul 25, 2013
Merged

remove notebook read-only view #3743

merged 1 commit into from Jul 25, 2013

Conversation

minrk
Copy link
Member

@minrk minrk commented Jul 23, 2013

it is largely broken, and had problematic security issues.

@minrk
remove notebook read-only view
961067e 
it is largely broken, and had problematic security issues.
@Carreau
Copy link
Member

Carreau commented Jul 25, 2013

Is this 1.0 material ?

@minrk
Copy link
Member Author

minrk commented Jul 25, 2013

I think so. @fperez @ellisonbg?

@ellisonbg
Copy link
Member

If we can do it for 1.0 that would be great.

On Wed, Jul 24, 2013 at 8:40 PM, Min RK notifications@github.com wrote:

I think so. @fperez https://github.com/fperez @ellisonbghttps://github.com/ellisonbg
?

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/3743#issuecomment-21531538
.

Brian E. Granger
Cal Poly State University, San Luis Obispo
bgranger@calpoly.edu and ellisonbg@gmail.com

@Carreau
Copy link
Member

Carreau commented Jul 25, 2013

Ok, just wanted info on that. Merging tomorrow if no objection until then.

Carreau added a commit that referenced this pull request Jul 25, 2013
@Carreau
Merge pull request #3743 from minrk/noro
c2464fa 
remove notebook read-only view

it is largely broken, and had problematic security issues.
@Carreau Carreau merged commit c2464fa into ipython:master Jul 25, 2013
@foobarbecue
Copy link

Oh no! I was using that. Any plans to replace it with similar functionality?

@minrk
Copy link
Member Author

minrk commented Sep 10, 2013

Yes - read-only view will be replaced by a static HTML render of the notebook produced by nbconvert (won't have wonky issues with disabling execution / input that current read-only had).

mattvonrocketstein pushed a commit to mattvonrocketstein/ipython that referenced this pull request Nov 3, 2014
@Carreau
Merge pull request ipython#3743 from minrk/noro
2f024cc 
remove notebook read-only view

it is largely broken, and had problematic security issues.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@minrk @Carreau @ellisonbg @foobarbecue