document the wire protocol #3756
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also change default hash to sha256 instead of md5, since md5 is bad. (this is the main motivation)
|
LGTM. |
|
In-person feedback from @ivanov, there are a few more things to add here. |
|
Hey, @minrk, we're at EECS, working in Woz if you want to swing by, we'd love to have you're expertise. |
stevengj
added a commit
to JuliaLang/IJulia.jl
that referenced
this pull request
Jul 25, 2013
|
+1 |
these are informally defined and have no effect, but we should be a bit better with them.
|
Should be closer to complete. Includes more fixes to inaccuracies found by the Julia Kernel |
ghost
assigned
|
Would you like to merge this as is and work on the rest later ? |
|
Sure |
minrk
added a commit
that referenced
this pull request
Jul 26, 2013
document the wire protocol in the messaging doc also update the digest scheme to use sha256 and make this configurable, since md5 is the previous default and has been shown to be bad. More messaging docs to update here: - [x] remove get/setattr on kernel - [x] remove crash messages - [x] completion requests do not behave as documented - [x] object_info is misdocumented (`name` is actually `oname` in object_info_request)
18 tasks
mattvonrocketstein
pushed a commit
to mattvonrocketstein/ipython
that referenced
this pull request
Nov 3, 2014
document the wire protocol in the messaging doc also update the digest scheme to use sha256 and make this configurable, since md5 is the previous default and has been shown to be bad. More messaging docs to update here: - [x] remove get/setattr on kernel - [x] remove crash messages - [x] completion requests do not behave as documented - [x] object_info is misdocumented (`name` is actually `oname` in object_info_request)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in the messaging doc
also update the digest scheme to use sha256 and make this configurable,
since md5 is the previous default and has been shown to be bad.
More messaging docs to update here:
nameis actuallyonamein object_info_request)