nbconvert: Filter names cleanup #3758
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
jdfreder
commented
Jul 24, 2013
jdfreder
commented
- highlight -> highlight2foo
- markdown -> markdown2html
- python_comment -> comment_lines
- rm_ansi -> strip_ansi
- rm_dollars -> strip_dollars
- rm_fake -> strip_files_prefix
- html_text -> html2text
- rm_math_space -> strip_math_space
- wrap -> wrap_text
…ered ok by mathjax after the nbconvertion.
| 'wrap': filters.wrap | ||
| 'strip_math_space': filters.strip_math_space, | ||
| 'wrap_text': filters.wrap_text, | ||
| 'escape_tex': filters.escape_latex |
There was a problem hiding this comment.
should these match instead of tex vs latex?
There was a problem hiding this comment.
Good catch, slipped my eye
|
did you merged @damianavilla PR into this one while renaming ? |
|
once this get in, I'll rebase/redo mine. |
|
No I didn't . I'll go ahead and do that though |
|
@Carreau I merged @damianavila 's work |
|
Test passing. Merging. |
Carreau
added a commit
that referenced
this pull request
Jul 25, 2013
nbconvert: Filter names cleanup highlight -> highlight2foo markdown -> markdown2html python_comment -> comment_lines rm_ansi -> strip_ansi rm_dollars -> strip_dollars rm_fake -> strip_files_prefix html_text -> html2text rm_math_space -> strip_math_space wrap -> wrap_text
mattvonrocketstein
pushed a commit
to mattvonrocketstein/ipython
that referenced
this pull request
Nov 3, 2014
nbconvert: Filter names cleanup highlight -> highlight2foo markdown -> markdown2html python_comment -> comment_lines rm_ansi -> strip_ansi rm_dollars -> strip_dollars rm_fake -> strip_files_prefix html_text -> html2text rm_math_space -> strip_math_space wrap -> wrap_text
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.