Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Organizing reveal's templates. #3770

Merged
merged 4 commits into from Jul 26, 2013
Merged

Organizing reveal's templates. #3770

merged 4 commits into from Jul 26, 2013

Conversation

damianavila
Copy link
Member

I added a folder to store all the intermediate templates of reveal.
In this way, there is less noise in the templates folder.

Cheers

@Carreau
Copy link
Member

Carreau commented Jul 25, 2013

This fails on 4 versions of Python, probably bacause reveal_internals/*.tpl are not installed, you should probably add this path in setup.py.

Ping @jdfreder to know his though on organizing in subfolders.

@damianavila
Copy link
Member Author

I added the path to setupbase... thx for the info... I was using setupegg.py inside a virtualenv and I missed this installation step (my test was passing w/o problems).

@jdfreder
Copy link
Member

@damianavila this is nice and was on my TODO list, thanks for doing this. I did something similar to this, appending reveal_ to the file names, but I like your method more.

@jdfreder
Copy link
Member

#3784

@damianavila
Copy link
Member Author

Yeah I think that grouping inside a folder makes the templates structure cleaner and less populated by intermediate states.

@jdfreder
Copy link
Member

👍 to merge for me, I'd like this to be in master so I can rebase for #3784

jdfreder added a commit that referenced this pull request Jul 26, 2013
@jdfreder jdfreder merged commit 66d42bc into ipython:master Jul 26, 2013
@damianavila damianavila deleted the group_reveal branch July 26, 2013 22:45
@damianavila
Copy link
Member Author

Thanks!

mattvonrocketstein pushed a commit to mattvonrocketstein/ipython that referenced this pull request Nov 3, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants