Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

comply with the message spec in the notebook #3781

Merged
merged 2 commits into from Jul 26, 2013

Conversation

minrk
Copy link
Member

@minrk minrk commented Jul 25, 2013

object_info is missing detail_level key
complete_request is missing block

@Carreau
Copy link
Member

Carreau commented Jul 25, 2013

should this go with the oname and name discussion I head about ?

+1

@minrk
Copy link
Member Author

minrk commented Jul 25, 2013

Yes and no - it is probably a mistake that we call it 'oname' in info_request, but we don't want to make a backward-incompatible change right now (later, perhaps)

Carreau added a commit that referenced this pull request Jul 26, 2013
comply with the message spec in the notebook
@Carreau Carreau merged commit c87ae0d into ipython:master Jul 26, 2013
@Carreau
Copy link
Member

Carreau commented Jul 26, 2013

Yes and no - it is probably a mistake that we call it 'oname' in info_request, but we don't want to make a backward-incompatible change right now (later, perhaps)

I was meaning do you want to fix the docs at the same time :-) but merged.

mattvonrocketstein pushed a commit to mattvonrocketstein/ipython that referenced this pull request Nov 3, 2014
comply with the message spec in the notebook
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants