Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skip tests that require pandoc #3792

Merged
merged 1 commit into from Jul 26, 2013
Merged

Conversation

ivanov
Copy link
Member

@ivanov ivanov commented Jul 26, 2013

I merged #3746 without running the test suite when I removed pandoc from my system, so it was my fault.

@ivanov
Copy link
Member Author

ivanov commented Jul 26, 2013

@jdfreder about these tests in general: they're all the same with just a different import line - is that going to stay the same? If so, I can add to this PR to unify all those tests so future such changes are made in one place, instead of 7 files

def test_export(self):
"""
Can a BasicHTMLExporter export something?
"""
(output, resources) = BasicHTMLExporter().from_filename(self._get_notebook())
assert len(output) > 0
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wolever - see, you aren't the only one ;)

@Carreau
Copy link
Member

Carreau commented Jul 26, 2013

Paul, you probably have a bad config to your editor, it seem to be
configured to add the following to every file you edit :

from IPython.testing.decorators import onlyif_cmds_exist
<...>
@onlyif_cmds_exist('pandoc')
<...>
<new line at EOF>

This does not adds no noise to many commits that are not done by people others than Min.

Don't be angry :-)

@Carreau
Copy link
Member

Carreau commented Jul 26, 2013

LGTM

@Carreau
Copy link
Member

Carreau commented Jul 26, 2013

Test actually passes. Merging.

Carreau added a commit that referenced this pull request Jul 26, 2013
@Carreau Carreau merged commit 0e8192c into ipython:master Jul 26, 2013
@jdfreder
Copy link
Member

@ivanov yeah, I could move them into the test_exporter.py. In the flavors/template (or what ever you want to call them) PR, the HTML and LaTeX tests also test the sub-templates (flavors/ whatever)... 🐫

@ivanov ivanov deleted the skip-without-pandoc branch July 26, 2013 17:55
@ivanov
Copy link
Member Author

ivanov commented Jul 26, 2013

This does not adds no noise to many commits that are not done by people others than Min.

SOO ANGRY.

mattvonrocketstein pushed a commit to mattvonrocketstein/ipython that referenced this pull request Nov 3, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants