New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
skip tests that require pandoc #3792
Conversation
@jdfreder about these tests in general: they're all the same with just a different import line - is that going to stay the same? If so, I can add to this PR to unify all those tests so future such changes are made in one place, instead of 7 files |
def test_export(self): | ||
""" | ||
Can a BasicHTMLExporter export something? | ||
""" | ||
(output, resources) = BasicHTMLExporter().from_filename(self._get_notebook()) | ||
assert len(output) > 0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@wolever - see, you aren't the only one ;)
Paul, you probably have a bad config to your editor, it seem to be
This does not adds no noise to many commits that are not done by people others than Min. Don't be angry :-) |
LGTM |
Test actually passes. Merging. |
skip tests that require pandoc
@ivanov yeah, I could move them into the test_exporter.py. In the flavors/template (or what ever you want to call them) PR, the HTML and LaTeX tests also test the sub-templates (flavors/ whatever)... 🐫 |
SOO ANGRY. |
skip tests that require pandoc
I merged #3746 without running the test suite when I removed pandoc from my system, so it was my fault.