add ConsoleWidget.execute_on_complete_input flag
#3814
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
disables input-parsing in the QtConsole, which is inappropriate for non-Python kernels. Disabling check_complete forces shift-enter to execute, just like the Notebook.
|
Could you comme up with a better name for the trait ? Otherwise I think this can go in 1.0 if it is for julia guys. |
|
What's a better name? It is disabling the check for complete input. I guess it's more specifically disabling automatic execution on complete input, so |
I like this one. I was just feeling that the other one would be completely opaque for someone who didn't new the internal of qtconsole. and it's easier to grep. |
better name for check_complete
Done. |
|
Would like to know what other dev think. But still +1 for 1.0 |
|
Got +1 from @fperez in meatspace. Merging. |
minrk
added a commit
that referenced
this pull request
Jul 29, 2013
add `ConsoleWidget.execute_on_complete_input` flag disables input-parsing in the QtConsole, which is inappropriate for non-Python kernels. Disabling execute_on_complete_input requires shift-enter to execute, just like the Notebook. Not sure if we want this for 1.0 or not. It's pretty trivial, but it is technically a new feature.
mattvonrocketstein
pushed a commit
to mattvonrocketstein/ipython
that referenced
this pull request
Nov 3, 2014
add `ConsoleWidget.execute_on_complete_input` flag disables input-parsing in the QtConsole, which is inappropriate for non-Python kernels. Disabling execute_on_complete_input requires shift-enter to execute, just like the Notebook. Not sure if we want this for 1.0 or not. It's pretty trivial, but it is technically a new feature.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
disables input-parsing in the QtConsole, which is inappropriate for non-Python kernels.
Disabling execute_on_complete_input requires shift-enter to execute, just like the Notebook.
Not sure if we want this for 1.0 or not. It's pretty trivial, but it is technically a new feature.