Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

s/pylab/matplotlib in docs #3816

Merged
merged 7 commits into from Jul 29, 2013
Merged

s/pylab/matplotlib in docs #3816

merged 7 commits into from Jul 29, 2013

Conversation

Carreau
Copy link
Member

@Carreau Carreau commented Jul 28, 2013

There are still actually quite a few places that reference --pylab ...

@minrk
Copy link
Member

minrk commented Jul 28, 2013

Any more?

@Carreau
Copy link
Member Author

Carreau commented Jul 28, 2013

Yes a lot. will push tomorrow, but need to read carefully to be sure we want to replace pylab by MPL. (like wave example)

@Carreau
Copy link
Member Author

Carreau commented Jul 28, 2013

Not that much and I'm actually wondering for many what we should do., like in ipapp.py:

 warn.warn("`-pylab` flag has been deprecated.\n"
            "    Use `--pylab` instead, or `--pylab=foo` to specify a backend.")
            sub = '--pylab'

Advise --matplotlib and to explicitely import pylab ?

@minrk
Copy link
Member

minrk commented Jul 28, 2013

Yes, I guess we should recommend --matplotlib there.

@minrk
Copy link
Member

minrk commented Jul 28, 2013

Will wait for you to ping before review/merge.

@Carreau
Copy link
Member Author

Carreau commented Jul 28, 2013

Ok for review. If you want to grep one more time, I may have missed some. A few example still have --pylab, but they should probably be re-written to work with --matplotlib. one of the other case where I didn't removed the --pylab was the plain ipython --pylab.

@@ -96,9 +96,8 @@
_examples = """
ipython notebook # start the notebook
ipython notebook --profile=sympy # use the sympy profile
ipython notebook --pylab=inline # pylab in inline plotting mode
ipython notebook --matplotlib=inline # inline plotting mode
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually remove this one - I don't think we should be recommending that anyone start the notebook with matplotlib enabled.

@minrk
Copy link
Member

minrk commented Jul 29, 2013

more in:

  • config/editors L81,83
  • config/overview L487
  • interactive/qtconsole L77,115,119,180, 549
  • parallel_demos L12

I can finish those up, if you want.

@Carreau
Copy link
Member Author

Carreau commented Jul 29, 2013

Sure, especially parallel I don't use it a lot and would prefer to have those tested.

@minrk
Copy link
Member

minrk commented Jul 29, 2013

PR sent against your branch

@Carreau
Copy link
Member Author

Carreau commented Jul 29, 2013

updated.

minrk added a commit that referenced this pull request Jul 29, 2013
s/pylab/matplotlib in docs

Remove most remaining mentions of `--pylab` in the docs.
@minrk minrk merged commit aa90f51 into ipython:master Jul 29, 2013
mattvonrocketstein pushed a commit to mattvonrocketstein/ipython that referenced this pull request Nov 3, 2014
mattvonrocketstein pushed a commit to mattvonrocketstein/ipython that referenced this pull request Nov 3, 2014
s/pylab/matplotlib in docs

Remove most remaining mentions of `--pylab` in the docs.
@Carreau Carreau deleted the depylab branch December 15, 2014 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants