try rtfd #3826
Merged
try rtfd #3826
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -32,7 +32,8 @@ | |||
|
|
|||
| # Import support for ipython console session syntax highlighting | |||
| # (lives IPython's sphinxext subpackage) | |||
| from IPython.sphinxext import ipython_console_highlighting | |||
| if not ON_RTD: | |||
| from IPython.sphinxext import ipython_console_highlighting | |||
There was a problem hiding this comment.
Does this need to be imported at all?
There was a problem hiding this comment.
You added it not so long ago, so I supposed it was.
|
fix, rebased and squashed. |
|
looks good to merge, though I don't actually see any failures on ReadTheDocs... |
|
@ivanov rtfd is not configured to build master by default. You are building the repo as it was 4 month ago. WIll change now that I am admin. |
mattvonrocketstein
pushed a commit
to mattvonrocketstein/ipython
that referenced
this pull request
Nov 3, 2014
Fix rtfd build.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix rtfd build.