New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Parse markdown correctly when mathjax is disabled #3836
Conversation
Hum, I suppose you discovered that in the plane :-) for the flight back you can install mathjax locally before taking off :-) will test with no internet connexion to see if it also works. |
Yeah, I just installed mathjax locally -- I will investigate further when I lose internet :-) |
I htink this is more a question of if (!window.MathJax) {
return text;
} Instead of a tuple of 2 elements |
Ahh, yeah, that makes more sense. I will update the pull request in a few hours when I can push from my laptop again. |
Good second flight. And work also on your PhD. :-) You might want to merge #3838 and set custom mathjax_url to simulate a fail to load mathjax now that you have local version :-) |
if (window.mathjax_url != "") { | ||
var text_math = IPython.mathjaxutils.remove_math(text); | ||
var text = text_math[0]; | ||
var math = text_math[1]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no var
on text
or math
here, they are both declared above.
(I know this isn't a change you introduced, but might as well fix it while we are here).
Alright, I updated the PR. I checked to see what happens when even with mathjax installed locally. Without the PR:
This should fix both cases 3 and 4. I went ahead and also fixed the code (which is basically identical) for heading cells, which suffer from the same bug. |
tested locally while off-network, and seems to work fine. 👍 to merge. |
Parse markdown correctly when mathjax is disabled Closes #3835
Le mardi 30 juillet 2013, Jessica B. Hamrick a écrit :
Thanks for the fix, have a lot of beer, hope you're not too jet lagged. I |
Ahhh, I see, that makes sense. In general I tend to prefer to differentiate between the cases when there's a failure vs a feature is disabled, but it doesn't matter now anyway. Thanks, and I will have lots of delicious german beer! :) |
Parse markdown correctly when mathjax is disabled Closes ipython#3835
This should resolve #3835