skip test on unix when x11 not available #3883
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
note that pylab_not_importable appears to not be enough to catch if we're running X. I'm able to import pylab, and it's only %%matplotlib magic that causes these tests to die
| @@ -314,6 +328,17 @@ def module_not_available(module): | |||
| skip_if_not_osx = skipif(sys.platform != 'darwin', | |||
| "This test only runs under OSX") | |||
|
|
|||
|
|
|||
| _x11_skip_cond = (sys.platform not in ('darwin', 'win32') and | |||
| os.environ['DISPLAY']=='') | |||
There was a problem hiding this comment.
Use getor this fails on system where DISPLAY is not defined like Travis. We do want to break master but not intentionally.
|
thanks @Carreau for taking a look, fixed that |
Carreau
added a commit
that referenced
this pull request
Aug 16, 2013
skip test on unix when x11 not available If you just use DISPLAY= iptest then Qt console tests were failing with a generic : cannot connect to X server
mattvonrocketstein
pushed a commit
to mattvonrocketstein/ipython
that referenced
this pull request
Nov 3, 2014
skip test on unix when x11 not available If you just use DISPLAY= iptest then Qt console tests were failing with a generic : cannot connect to X server
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you just use
DISPLAY= iptestthen Qt console tests were failing with ageneric
: cannot connect to X server