Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

posixify paths for Windows latex #3888

Merged
merged 4 commits into from Aug 4, 2013
Merged

posixify paths for Windows latex #3888

merged 4 commits into from Aug 4, 2013

Conversation

minrk
Copy link
Member

@minrk minrk commented Aug 3, 2013

latex on Windows apparently doesn't support Windows paths.

alternative to #3886

closes #3885

mainly for unixy things on Windows (latex) that don't allow Windows paths.
@ivanov
Copy link
Member

ivanov commented Aug 3, 2013

adding the import os in IPython/nbconvert/filters/tests/test_strings.py wasn't enough here, os.path.join needed an unpacked list. Sent you a PR with both, @minrk

add missing import, properly use os.path.join
@minrk
Copy link
Member Author

minrk commented Aug 4, 2013

merged @ivanov's fixes here.

@ivanov
Copy link
Member

ivanov commented Aug 4, 2013

restarted Travis, will merge as soon as it greenlights

@ivanov
Copy link
Member

ivanov commented Aug 4, 2013

ok, green light, merging! thanks @minrk

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants