Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added check_for_tornado, closes #3916 #3918

Merged
merged 1 commit into from Aug 6, 2013
Merged

Conversation

ivanov
Copy link
Member

@ivanov ivanov commented Aug 6, 2013

This way, those relying on the output of python setup.py install get clued
in about the fact that it is required for the notebook

This way, those relying on the output of `python setup.py install` get
clued in about the fact that it is required for the notebook
@Carreau
Copy link
Member

Carreau commented Aug 6, 2013

Are we still compatible tornado < 3 ?

@ivanov
Copy link
Member Author

ivanov commented Aug 6, 2013

In [1]: import tornado

In [2]: tornado.version
Out[2]: '2.4.1'

and it works for me

minrk added a commit that referenced this pull request Aug 6, 2013
added check_for_tornado

closes #3916
@minrk minrk merged commit 59270a6 into ipython:master Aug 6, 2013
mattvonrocketstein pushed a commit to mattvonrocketstein/ipython that referenced this pull request Nov 3, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants