Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

swallow enter event in rename dialog #3929

Merged
merged 1 commit into from Aug 7, 2013
Merged

Conversation

minrk
Copy link
Member

@minrk minrk commented Aug 7, 2013

avoids adding newline in cell after dialog is closed.

closes #3926

avoids adding newline in cell after dialog is closed.

closes ipython#3926
@Carreau
Copy link
Member

Carreau commented Aug 7, 2013

lgtm

minrk added a commit that referenced this pull request Aug 7, 2013
swallow enter event in rename dialog

avoids adding newline in cell after dialog is closed.

closes #3926
@minrk minrk merged commit 3879f00 into ipython:master Aug 7, 2013
@minrk minrk deleted the rename-cr branch August 7, 2013 17:11
mattvonrocketstein pushed a commit to mattvonrocketstein/ipython that referenced this pull request Nov 3, 2014
swallow enter event in rename dialog

avoids adding newline in cell after dialog is closed.

closes ipython#3926
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ending Notebook renaming dialog with return creates new-line
2 participants