Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nbconvert: Post-processor tests #3933

Merged
merged 2 commits into from Aug 10, 2013
Merged

nbconvert: Post-processor tests #3933

merged 2 commits into from Aug 10, 2013

Conversation

jdfreder
Copy link
Member

@jdfreder jdfreder commented Aug 7, 2013

Adds 3 small tests for the post processors.

@stonebig
Copy link
Contributor

stonebig commented Aug 7, 2013

Hello,

Shouldn't you check also that os.path.getctime('a.pdf') >= os.path.getctime('a.tex') ?
(to be sure that the pdf has really just been made)

@jdfreder
Copy link
Member Author

jdfreder commented Aug 7, 2013

os.path.getctime('a.pdf') > os.path.getctime('a.tex')

The test works in a new empty temp directory that it creates. See create_temp_cwd in IPython.nbconvert.tests.base.TestsBase.

@jdfreder
Copy link
Member Author

jdfreder commented Aug 7, 2013

@Carreau
Copy link
Member

Carreau commented Aug 10, 2013

Looks good too.

@jdfreder
Copy link
Member Author

bump 🚗, What do you think @minrk ?

minrk added a commit that referenced this pull request Aug 10, 2013
nbconvert: Post-processor tests
@minrk minrk merged commit a886d6e into ipython:master Aug 10, 2013
@jdfreder jdfreder deleted the pproc_tests branch March 10, 2014 18:43
mattvonrocketstein pushed a commit to mattvonrocketstein/ipython that referenced this pull request Nov 3, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants