Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make tab visible in codemirror and light red background #3937

Merged
merged 2 commits into from Aug 12, 2013

Conversation

Carreau
Copy link
Member

@Carreau Carreau commented Aug 7, 2013

Shoudl fix #3935

before merging, I would like to find out why there is one line which is suppressed in IPython/html/static/style/ipython.min.css
capture decran 2013-08-07 a 21 00 51

@Carreau
Copy link
Member Author

Carreau commented Aug 7, 2013

On top of #3938

@arijun
Copy link

arijun commented Aug 7, 2013

The heavy blocks might look a bit overbearing but should do the trick. If cut and pasted back out of the notebook, would the indicators be copied as well, or would they be converted back to tabs? Probably the latter is more desirable.

@minrk
Copy link
Member

minrk commented Aug 7, 2013

@arijun the tabs are not replaced by anything, this is just the CSS styling of the tabs. So copy/paste should work normally.

@Carreau red warning might be a bit much, maybe just the symbol and no background?

@minrk
Copy link
Member

minrk commented Aug 7, 2013

marking for 2.0.

@Carreau
Copy link
Member Author

Carreau commented Aug 8, 2013

red warning might be a bit much, maybe just the symbol and no background?

I found the symbol only a little too discreet, especially if you have only one. And as you should never have tab in notebook (for Python at least) user should never see the red. Also for me just the symbol would not mean that something is wrong.

But I have no strong feeling against removing he red. I`ll try to see if I can make the arrow red, without background.

@minrk
Copy link
Member

minrk commented Aug 8, 2013

I think just the symbol is pretty clear:

screen shot 2013-08-08 at 11 48 00

@damianavila
Copy link
Member

Red background is too much, having into account the "light" theme of the notebook, red blocks are disturbing, I think...

@Carreau
Copy link
Member Author

Carreau commented Aug 9, 2013

I'll remove it then. But keep in mind that there should never be tab in a notebook cell. So at best users will never see that.

@Carreau
Copy link
Member Author

Carreau commented Aug 9, 2013

Red removed, and rebased.

@damianavila
Copy link
Member

Great

Carreau added a commit that referenced this pull request Aug 12, 2013
make tab visible in codemirror
@Carreau Carreau merged commit 9643317 into ipython:master Aug 12, 2013
@Carreau Carreau deleted the redtab branch August 12, 2013 07:02
mattvonrocketstein pushed a commit to mattvonrocketstein/ipython that referenced this pull request Nov 3, 2014
make tab visible in codemirror
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No feedback for mixed tabs and spaces
4 participants