minor checkpoint cleanup #3939
Merged
minor checkpoint cleanup #3939
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- remember list of checkpoints browser-side - cleanup references in MenuBar restore list. There was a closure issue, where multiple menu items would actually all restore the same checkpoint.
|
@rgbkrk, if you want to test this with your repo, I think it should be better behaved. |
|
Neat! I'll test against this commit. |
|
This is awesome! It's totally seamless and works flawlessly. Was able to restore to several different checkpoints while working with a notebook. It all worked as it should. |
|
👍 Is there some amount of testing or other work I could do to get this PR into 1.0? |
|
I think this has missed the cutoff for 1.0. I will make sure it's in the first 1.x bugfix release, though. |
|
Cool. I'll just have bookstore release with single checkpoint for now (multi is on GitHub, not on PyPI yet). |
|
Looks good to me, and seeing comment, merging. |
Carreau
added a commit
that referenced
this pull request
Aug 10, 2013
minor checkpoint cleanup remember list of checkpoints browser-side don't clobber list when a new checkpoint is created cleanup references in MenuBar restore list. There was a closure issue, where multiple menu items would actually all restore the same checkpoint.
minrk
added a commit
that referenced
this pull request
Aug 10, 2013
- remember list of checkpoints browser-side - don't clobber list when a new checkpoint is created - cleanup references in MenuBar restore list. There was a closure issue, where multiple menu items would actually all restore the same checkpoint. Issues revealed by rgbkrk/bookstore, which supports multiple checkpoints. I'm fine if this doesn't get into 1.0, given timing.
mattvonrocketstein
pushed a commit
to mattvonrocketstein/ipython
that referenced
this pull request
Nov 3, 2014
minor checkpoint cleanup remember list of checkpoints browser-side don't clobber list when a new checkpoint is created cleanup references in MenuBar restore list. There was a closure issue, where multiple menu items would actually all restore the same checkpoint.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a closure issue, where multiple menu items would actually all
restore the same checkpoint.
Issues revealed by rgbkrk/bookstore, which supports multiple checkpoints.
I'm fine if this doesn't get into 1.0, given timing.