log fatal error when PDF conversion fails #3949
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
don't user batch mode, which suppresses too much output
Merged
| p = subprocess.Popen(command, stdout=stdout, stdin=null) | ||
| out, err = p.communicate() | ||
| if p.returncode: | ||
| if self.verbose: |
There was a problem hiding this comment.
Isn't this logic backwards? If verbose, output should be preserved...
There was a problem hiding this comment.
if verbose, output has already been displayed (it was not swallowed by the pipe, so out is None).
|
👍 |
minrk
added a commit
that referenced
this pull request
Aug 8, 2013
log fatal error when PDF conversion fails
mattvonrocketstein
pushed a commit
to mattvonrocketstein/ipython
that referenced
this pull request
Nov 3, 2014
log fatal error when PDF conversion fails
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
don't user batch mode, which suppresses too much output
finish up PR #3948