Add REPL-like printing of final/return value to %%R cell magic #4017
Conversation
| the value generated by evaluating the code (see below) | ||
|
|
||
| In line mode (ie called with %R <stuff>), behavior | ||
| is unchanged, returns a python object representing |
There was a problem hiding this comment.
'unchanged' won't be meaningful in a year's time when people don't remember the previous behaviour.
|
I have attempted to address the ambiguity and lack of clarity in the docstrings. |
| @@ -182,19 +182,42 @@ def __init__(self, shell, Rconverter=Rconverter, | |||
| self.pyconverter = pyconverter | |||
| self.Rconverter = Rconverter | |||
|
|
|||
| def eval(self, line): | |||
| def eval(self, line, line_mode): | |||
There was a problem hiding this comment.
Let's give line_mode a default value so it's clear that it's a boolean.
|
On further thought, I think it would make more sense for the magic function to do the printing, so Other than that, I think this is looking good. |
|
Good idea. I'll push the suggested changes to the PR shortly. Thanks. On Tue, Aug 13, 2013 at 3:23 PM, Thomas Kluyver notifications@github.comwrote:
Gabriel Becker |
|
just want to link this to #3803 and make the PR author aware of the coming change. |
| text_output += text_result | ||
| if(visible): |
There was a problem hiding this comment.
if visible: doesn't need brackets in Python ;-)
|
Thanks, merging. |
Add REPL-like printing of final/return value to %%R cell magic
Add REPL-like printing of final/return value to %%R cell magic
This change makes the behavior of the %%R cell level magic in the rmagic extension agree with the behavior of both R code in other venues (the R program/RStudio/etc) and with python code within the notebook by treating the code/return value as if it was evaluated within a REPL.p
R's built-in facilities are used to both evaluate the code and determine whether the final value should be printed or not, guaranteeing correct behavior.
This change makes it much more convenient to use R within the notebook framework and also fixes the well-known issue of having to call print when using R's non-base graphics capabilities (ie lattice or ggplot2).
No change is made to the behaviour of the %R line-level magic.