Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename post_processors submodule to postprocessors #4073

Merged
merged 3 commits into from Aug 21, 2013

Conversation

jakevdp
Copy link
Contributor

@jakevdp jakevdp commented Aug 20, 2013

As mentioned on the ML

@jdfreder
Copy link
Member

Only one minor comment, it would probably be a good idea to renamed the local variables in nbconvertapp too. I made a PR against this branch that fixes this.

@jdfreder
Copy link
Member

Other than that, it looks good to me. Tested on my machine and it still seems to work.

Also renamed local variables in nbconvertapp
@jakevdp
Copy link
Contributor Author

jakevdp commented Aug 21, 2013

Great -- I merged your changes into the branch.

jdfreder added a commit that referenced this pull request Aug 21, 2013
rename ``post_processors`` submodule to ``postprocessors``
@jdfreder jdfreder merged commit acdfd6e into ipython:master Aug 21, 2013
@jdfreder
Copy link
Member

Thanks!

@minrk
Copy link
Member

minrk commented Aug 21, 2013

@jdfreder - please wait for review before merging. I don't think the postprocessor variable name change was correct.

@jdfreder
Copy link
Member

Yes, Paul already yelled at me, sorry

@ivanov
Copy link
Member

ivanov commented Aug 21, 2013

to be fair, here's what I actually said:

Hey @jon i see you merged 4073 - Thomas and I should probably communicate this better, but we were going to wait to merge that one, since it's kind of a trivial change, but it now makes one of @ThomasKluyver's non-trivial PRs conflict

you'll know when I'm actually yelling at you, but this wasn't one of those times ;)

@jdfreder
Copy link
Member

you'll know when I'm actually yelling at you

Let's hope that never happens , @ :angry_paul:

@ivanov
Copy link
Member

ivanov commented Aug 21, 2013

so. angry. :rage4:

mattvonrocketstein pushed a commit to mattvonrocketstein/ipython that referenced this pull request Nov 3, 2014
rename ``post_processors`` submodule to ``postprocessors``
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants