trigger Kernel.status_started after websockets open
#4079
Merged
+23
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This leads to a more logical state for event watchers to expect.
|
|
||
| var channels = [this.shell_channel, this.iopub_channel, this.stdin_channel]; | ||
| for (var i=0; i < channels.length; i++) { | ||
| // if any channel is not ready, don't trigger event. |
There was a problem hiding this comment.
Just curious about the logic: if a channel isn't ready and the early exit is forced, is there a chance for this event to fire later when those channels are ready? Should there be a similar event triggered when the channels become ready to ensure that once the last one is ready, the event is always sent?
There was a problem hiding this comment.
I don't think I understand the question. The event will only be triggered if all three connections are ready. If the early-close event fires before they are all ready, the started event will never fire because the websockets will be closed.
|
Merging soon unless I hear otherwise. |
Soon was 9 days ago. Shall I merge ? |
Carreau
added a commit
that referenced
this pull request
Sep 13, 2013
trigger `Kernel.status_started` after websockets open
mattvonrocketstein
pushed a commit
to mattvonrocketstein/ipython
that referenced
this pull request
Nov 3, 2014
trigger `Kernel.status_started` after websockets open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This leads to a more logical state for event watchers to expect.