nbconvert: Fix coalescestreams line with incorrect nesting causing strange behavior #4088
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
can you add a test that shows that would fail before the fix? Generally a good idea every time we fix a bug like this. |
|
Can this PR be backported? (see tags in #4015) |
|
it should be, yes. It has to be finished and merged into master first. |
|
Any time an Issue is marked for backport, it means that its fix should be backported. |
|
I'll add the test now |
minrk
added a commit
that referenced
this pull request
Aug 29, 2013
nbconvert: Fix coalescestreams line with incorrect nesting causing strange behavior closes #4015
mattvonrocketstein
pushed a commit
to mattvonrocketstein/ipython
that referenced
this pull request
Nov 3, 2014
nbconvert: Fix coalescestreams line with incorrect nesting causing strange behavior closes ipython#4015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4015