Fix clashes between debugger tests and coverage.py #4102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coverage.py works by setting the trace function. But so does the debugger, so we need to re-set it afterwards to get accurate coverage results.
|
Merging some time tomorrow, or after the weekend, unless anyone objects. |
|
In it goes. |
takluyver
added a commit
that referenced
this pull request
Aug 27, 2013
Fix clashes between debugger tests and coverage.py
mattvonrocketstein
pushed a commit
to mattvonrocketstein/ipython
that referenced
this pull request
Nov 3, 2014
Fix clashes between debugger tests and coverage.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
coverage.py works by setting the trace function. But so does the debugger, so we need to re-set it after testing the debugger to get accurate coverage results.
I noticed a disparity between the coverage numbers for Python 2 and 3, which seems to be down to the order in which tests are executed. Hopefully this will fix it.