use TextIOWrapper when communicating with pandoc subprocess #4205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uses 'universal-newline' mode, to avoid confusion with CRLF. closes ipython#4122
This was referenced Sep 13, 2013
|
The alternative would be to |
|
That sounds like a job for |
|
TextIOWrapper is about 2-5x as fast as split/rejoin (not that this is ever an expensive operation), so I'll stick with the current implementation. |
|
Great, my tests showed a smaller difference in the same direction. |
|
Adding a test before merging. |
|
test added and passed on OS X and Windows 7, just waiting on Travis. |
|
Travis is happy as well. Merging. |
takluyver
added a commit
that referenced
this pull request
Sep 14, 2013
use TextIOWrapper when communicating with pandoc subprocess
mattvonrocketstein
pushed a commit
to mattvonrocketstein/ipython
that referenced
this pull request
Nov 3, 2014
use TextIOWrapper when communicating with pandoc subprocess
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
uses 'universal-newline' mode, to avoid any confusion with CRLF.
closes #4122
closes #3819
alternative to #4202