Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clear previous callbacks on execute #4224

Merged
merged 2 commits into from Sep 20, 2013
Merged

clear previous callbacks on execute #4224

merged 2 commits into from Sep 20, 2013

Conversation

minrk
Copy link
Member

@minrk minrk commented Sep 17, 2013

avoids mixed up display of multiple executions in one output area when a
cell is resubmitted.

closes #4223

@minrk
add Kernel.clear_callbacks_for_msg
1d92dd0
@minrk
clear previous callbacks on execute
b0efb86 
avoids mixed up display of multiple executions in one output area
when a cell is resubmitted.

closes ipython#4223
@minrk minrk mentioned this pull request Sep 17, 2013
Closed
@ellisonbg
Copy link
Member

For widgets that use execute on browser-side change events, this PR will mean that execute requests queued on the kernel are lost. If a user keeps making changes to a widget before the queue is emptied, nothing will ever show up in the output area. That will be extremely confusing to users who will keep moving the UI controls trying to get something to show up - which itself will only prolong the problem. I understand why we need to fix this, but I am wondering if we can use an approach that is a little more liberal about this behavior.

@minrk
Copy link
Member Author

minrk commented Sep 17, 2013

For widgets that use execute on browser-side change events, this PR will mean that execute requests queued on the kernel are lost.

I don't think so. This only affects the previous call to cell.execute, not the previous call to kernel.execute. I should hope that widgets do not actually call cell.execute.

@ellisonbg
Copy link
Member

The code looks solid. I tested the behavior and it works as expected. Merging...

ellisonbg added a commit that referenced this pull request Sep 20, 2013
@ellisonbg
Merge pull request #4224 from minrk/clear_callbacks
154a640 
clear previous callbacks on execute
@ellisonbg ellisonbg merged commit 154a640 into ipython:master Sep 20, 2013
@minrk minrk deleted the clear_callbacks branch October 2, 2013 19:08
mattvonrocketstein pushed a commit to mattvonrocketstein/ipython that referenced this pull request Nov 3, 2014
@ellisonbg
Merge pull request ipython#4224 from minrk/clear_callbacks
c946ab0 
clear previous callbacks on execute
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.0
Development

Successfully merging this pull request may close these issues.

Double output on Ctrl-enter-enter
2 participants
@minrk @ellisonbg