New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clear_output: Animation & widget related changes. #4229
Conversation
review from dev meeting: remove the height-fixing when wait=False |
Thanks, changes made ^ |
The code looks great, but can you update our example notebook that shows how to use this stuff: |
@ellisonbg thanks, changes made ^ |
A few other places where we should probably use
You will need MPI to run those last two notebooks - don't worry about that - just update the code. |
This PR should also add an entry in the what's new in |
@ellisonbg thanks, changes made again ^ |
|
||
* There is no longer a 500ms delay when calling ``clear_output``. | ||
* The ability to clear stderr and stdout individually was removed. | ||
* A new wait flag that prevents ``clear_output`` from being executed until new |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
put wait in double backticks here.
Thanks @ellisonbg , changes made |
OK everything is done, merging. |
Clear_output: Animation & widget related changes.
@@ -300,6 +305,7 @@ var IPython = (function (IPython) { | |||
this.append_stream(json); | |||
} | |||
this.outputs.push(json); | |||
this.element.height('auto'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this auto height the right behavior, or was that a remnant from the previous implementation?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It still measures/sets the height if wait=True
, this line is supposed to reset that. So yes & yes.
If parsing javascript threadlocks the browser's render function, this is pointless since it wont redraw in between clear_output
and the append operation. Do you have insight to whether or not this is the case?
Ahhhhhhhh !!!!!
I cannot have output that scroll now.... the scoll area cannot be smaller than the output anymooooooooooore run
and now... suffer ! |
Shoot, that's a problem... If I put a conditional around the auto-height that should be enough to fix the problem. I doubt you want scrolling output for rapid animations, right? |
Fix scrolling output (not working post clear_output changes) Regression introduced in #4229
Regression introduced in ipython#4229
Regression introduced in ipython#4229
Clear_output: Animation & widget related changes.
Fix scrolling output (not working post clear_output changes) Regression introduced in ipython#4229
Regression introduced in ipython#4229
Animation flickering also mentioned in #1563
Some of the behaviors that were unwanted can be seen in this YouTube video.