Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no highlight if no language specified #4232

Merged
merged 1 commit into from Sep 20, 2013

Conversation

minrk
Copy link
Member

@minrk minrk commented Sep 19, 2013

This matches behavior of places like GitHub, where if you do not specify a language, e.g.

```
no_highlighting("here")
```

There is no syntax highlighting. You must do

```python
def foo(a="hi"):
    return 5
```

to enable highlighting in a particular language.

With configuration as it is right now in IPython, it is impossible to disable syntax highlighting in markdown blocks.

@minrk
Copy link
Member Author

minrk commented Sep 19, 2013

ping @StefanKarpinski

@Carreau
Copy link
Member

Carreau commented Sep 19, 2013

Looks good to me.

@ellisonbg
Copy link
Member

I think this is the right behavior, looks good, merging.

ellisonbg added a commit that referenced this pull request Sep 20, 2013
no highlight if no language specified
@ellisonbg ellisonbg merged commit 6694032 into ipython:master Sep 20, 2013
minrk added a commit that referenced this pull request Dec 24, 2013
This matches behavior of places like GitHub, where if you do not specify a language, e.g.

    ```
    no_highlighting("here")
    ```

There is no syntax highlighting. You must do

    ```python
    def foo(a="hi"):
        return 5
    ```

to enable highlighting in a particular language.

With configuration as it is right now in IPython, it is impossible to disable syntax highlighting in markdown blocks.
@minrk minrk deleted the no-lang-no-highlight branch March 31, 2014 23:36
mattvonrocketstein pushed a commit to mattvonrocketstein/ipython that referenced this pull request Nov 3, 2014
no highlight if no language specified
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants