New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adjust tab completion widget if too close to bottom of page. #4281
Conversation
The completer wraps mathjax equation? I'm wondering about reversing order, muscle memory can be pretty strong. |
I am with @Carreau here... you are inverting the order depending on the position of the widget... so sometimes the list is not inverted and sometimes it is inverted... this dual behaviour could be confusing for some people... |
Added to the list of topics for the dev meeting... On Thu, Sep 26, 2013 at 5:30 AM, Damián Avila notifications@github.comwrote:
Brian E. Granger |
As discussed in the dev meeting I have removed the completion list inversion. |
$('body').append(this.complete); | ||
|
||
// After everything is on the page compute the postion. | ||
// We invert the completion list and put it above the code if it is too |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You don't invert anymore, you can remove the comment.
@ellisonbg Do you think you can fix the small comment ? I can also issue another PR with the comment fix, or a PR against your PR. |
@Carreau just fixed it, this should be ready to go. |
Thanks, merging. |
Adjust tab completion widget if too close to bottom of page.
Adjust tab completion widget if too close to bottom of page.
In master the tab completely widget completely fails if the code is too low on the page and the widget won't fit.
This PR looks to see if the completely widget will fit below the code and if not does the following:
Here is a screenshot: