Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust tab completion widget if too close to bottom of page. #4281

Merged
merged 3 commits into from Oct 5, 2013

Conversation

ellisonbg
Copy link
Member

In master the tab completely widget completely fails if the code is too low on the page and the widget won't fit.

This PR looks to see if the completely widget will fit below the code and if not does the following:

  • Inverts the list
  • Scrolls to the bottom
  • Puts the widget above the code

Here is a screenshot:

screen shot 2013-09-25 at 7 20 46 pm

@ellisonbg
Copy link
Member Author

It does a pretty good job:

screen shot 2013-09-25 at 7 29 06 pm

@Carreau
Copy link
Member

Carreau commented Sep 26, 2013

The completer wraps mathjax equation?

I'm wondering about reversing order, muscle memory can be pretty strong.

@damianavila
Copy link
Member

I am with @Carreau here... you are inverting the order depending on the position of the widget... so sometimes the list is not inverted and sometimes it is inverted... this dual behaviour could be confusing for some people...

@ellisonbg
Copy link
Member Author

Added to the list of topics for the dev meeting...

On Thu, Sep 26, 2013 at 5:30 AM, Damián Avila notifications@github.comwrote:

I am with @Carreau https://github.com/Carreau here... you are inverting
the order depending on the position of the widget... so sometimes the list
is not inverted and sometimes it is inverted... this dual behaviour could
be confusing for some people...


Reply to this email directly or view it on GitHubhttps://github.com//pull/4281#issuecomment-25163535
.

Brian E. Granger
Cal Poly State University, San Luis Obispo
bgranger@calpoly.edu and ellisonbg@gmail.com

@ellisonbg
Copy link
Member Author

As discussed in the dev meeting I have removed the completion list inversion.

$('body').append(this.complete);

// After everything is on the page compute the postion.
// We invert the completion list and put it above the code if it is too
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You don't invert anymore, you can remove the comment.

@ghost ghost assigned ellisonbg Sep 28, 2013
@Carreau
Copy link
Member

Carreau commented Oct 3, 2013

@ellisonbg Do you think you can fix the small comment ? I can also issue another PR with the comment fix, or a PR against your PR.

@ellisonbg
Copy link
Member Author

@Carreau just fixed it, this should be ready to go.

@Carreau
Copy link
Member

Carreau commented Oct 5, 2013

Thanks, merging.

Carreau added a commit that referenced this pull request Oct 5, 2013
Adjust tab completion widget if too close to bottom of page.
@Carreau Carreau merged commit 3ad718f into ipython:master Oct 5, 2013
@ellisonbg ellisonbg deleted the complete_above branch January 28, 2014 17:48
mattvonrocketstein pushed a commit to mattvonrocketstein/ipython that referenced this pull request Nov 3, 2014
Adjust tab completion widget if too close to bottom of page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants