improve js-completer logic. #4292
Merged
+38
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| this.close(); | ||
| return; | ||
| } | ||
|
|
||
| this.autopick = false; | ||
| if (ff != 'undefined' && ff == true) { | ||
| if ( first_invocation ) { |
There was a problem hiding this comment.
Just cosmetic... but why spaces around first_invocation? ;-)
|
spaces fixed. |
Some configurability for Julia (change the regexp because ! is a valid char in token from them)
|
Rebased / Squashed and pass jslint on it to clean up a little more. |
|
Great! Looks good. |
2 tasks
|
I'll merge this guy. |
mattvonrocketstein
pushed a commit
to mattvonrocketstein/ipython
that referenced
this pull request
Nov 3, 2014
improve js-completer logic.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partial fix to #3653 (from foo import
<tab>)Some configurability for Julia
(change the regexp because ! is a valid char in token from them)
In notebook you can deactivate tooltip on tab
IPython.config.tooltip_on_tab = falsein js console (shift tab still request tooltip). Then doing afrom numpy import <tab>should work.