Factorise code in tooltip for julia monkeypatching #4293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
feedback someone ? |
|
I think this makes sense, but it points to a general shortcoming of the message spec as Python-specific. The Kernel should generally be allowed to do lexing, so that we don't have to make language-agnostic decisions in the frontend. |
|
That was one of the reason I was proposing the merge of object_info_request and complete request also. |
|
They do have that in common, but that mainly means they should have some keys and behaviors in common, not that they should actually be merged into one message type. |
|
Should we put that into the Hackpad ? |
2 tasks
|
I'll merge this as is, and issue a later PR that will deactivate tooltip on tab by default as discussed on todays meeting. |
Carreau
added a commit
that referenced
this pull request
Oct 17, 2013
Factorise code in tooltip for julia monkeypatching
mattvonrocketstein
pushed a commit
to mattvonrocketstein/ipython
that referenced
this pull request
Nov 3, 2014
Factorise code in tooltip for julia monkeypatching
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should allow IJulia to just set
Tooltip.last_token_reto another regexp, in their profileor even
Tooltip.prototype.extract_oir_tokenif they want their full customlogic to extract the token they want the info of in js.
Otherwise, right now they send their own version of
tooltip.js