Add even more ways to populate localinterfaces #4305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also typically faster and more reliable than gethostbyname, but lower priority than netifaces.
|
This branch solves my startup problems both with and without netifaces installed. |
| return _load_ips_ifconfig() | ||
| except (IOError, NoIPAddresses): | ||
| pass | ||
| try: |
There was a problem hiding this comment.
I don't see the need of if os.name == 'nt': here if what are in the 2 cases are ~ same for the first block.
There was a problem hiding this comment.
it's ipconfig (Windows only) and ifconfig (non-Windows), not the same.
There was a problem hiding this comment.
Ah, yes... hard to spot.
Thanks.
|
+1 |
|
As discussed in hangout, Min will try on other os like solaris...etc. |
|
works on OpenIndiana (successor to OpenSolaris), FreeBSD, OpenSUSE, etc. Seems safe. |
|
great, merging soon if no objection from anyone. |
Carreau
added a commit
that referenced
this pull request
Oct 6, 2013
Add even more ways to populate localinterfaces use netifaces for faster IPython.utils.localinterfaces when availlable, Parse subprocess output from ifconfig / ip addr / ipconfig. Lower priority than netifaces, but still higher priority than socket.gethostbyname. Fallback to gethostname otherwise. Should be much faster in worst case scenario where machine are badly configurred and can wait up to ~30s to start ipython. Slighly slower in other cases.
mattvonrocketstein
pushed a commit
to mattvonrocketstein/ipython
that referenced
this pull request
Nov 3, 2014
Add even more ways to populate localinterfaces use netifaces for faster IPython.utils.localinterfaces when availlable, Parse subprocess output from ifconfig / ip addr / ipconfig. Lower priority than netifaces, but still higher priority than socket.gethostbyname. Fallback to gethostname otherwise. Should be much faster in worst case scenario where machine are badly configurred and can wait up to ~30s to start ipython. Slighly slower in other cases.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parse subprocess output from
ifconfig/ip addr/ipconfig.Lower priority than
netifaces, but still higher priority thansocket.gethostbyname.More elaborate alternative to #4304