fix initial sys.path #4318
Merged
fix initial sys.path #4318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
recent change caused initial sys.path to lose '' as the first element in the notebook. closes ipython#4317
|
Is there a sane way to add a test for this? |
both when `--profile-dir` is specified, and when it is not.
|
Test added. |
|
looks good. |
| @@ -46,6 +47,21 @@ def test_simple_print(): | |||
| _check_mp_mode(kc, expected=False) | |||
|
|
|||
|
|
|||
| def test_sys_path(): | |||
| """test that sys.path doesn't get messed up by default""" | |||
| with kernel() as kc: | |||
There was a problem hiding this comment.
This is reusing a kernel, so we should remember that it can be affected by other tests. However, I don't think we should make it use another new kernel, because that's a substantial extra slowdown for a quite trivial test.
mattvonrocketstein
pushed a commit
to mattvonrocketstein/ipython
that referenced
this pull request
Nov 3, 2014
fix initial sys.path
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
recent change caused initial sys.path to lose '' as the first element in the
notebook.
closes #4317