Some changes to improve readability. #4325
Conversation
| @@ -6,7 +6,7 @@ | |||
| <html> | |||
| <head> | |||
|
|
|||
| <meta charset="utf-8" /> | |||
| <meta charset="utf-8"> | |||
| <meta http-equiv="X-UA-Compatible" content="chrome=1"> | |||
|
|
|||
| <meta name="apple-mobile-web-app-capable" content="yes" /> | |||
There was a problem hiding this comment.
We remove from here... or we also put it in the full_html template... no preference, just I want to have the same in both templates.
There was a problem hiding this comment.
For html 5 / is syntactic sugar, for meta which is is a void element I just think then we should keep the same thig everywhere either never / or always /. Keeping / would increase compatibility with xhtml (I think). but the issue can be pretty subtle
There was a problem hiding this comment.
I added the / to both templates ;-)
|
Small comment, but +1 globally. |
| @@ -5,8 +5,9 @@ | |||
| <!DOCTYPE html> | |||
| <html> | |||
| <head> | |||
| <meta charset="UTF-8"> | |||
| <title>[{{nb.metadata.name}}]</title> | |||
There was a problem hiding this comment.
This <title> tag seems to have gone missing - was that deliberate?
There was a problem hiding this comment.
yes; nb.metadata.name is empty now...
There was a problem hiding this comment.
But that doesn't mean we shouldn't set the title, it just means we were setting it wrong. Isn't there something in resources that we can use?
There was a problem hiding this comment.
Maybe here:
There was a problem hiding this comment.
OK, I missed that it was reintroduces when file was read...
|
Need rebases also. |
|
Rebased and added titles to |
|
Looks good to me. @Carreau , feel free to merge if there's nothing else you want to check. |
|
Nothing to add, thanks, merging. |
Some changes to improve readability.
|
Thanks! |
Some changes to improve readability.
As the title says... some changes in spaces to improve readability and to keep an uniform style in the htm-based templates.